deps: update ada to 4.0.0 - #64790
Open
nodejs-github-bot wants to merge 4 commits into
Open
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
avivkeller
added
the
semver-major
Member
|
Bump from v3 -> v4, semver-major, I presume |
Member
|
This is not a semver major change. It's a major bump because we started providing a new API to limit the max size of a URL which was 4gb. |
anonrig
removed
the
semver-major
Member
|
This goes hand-in-hand with #64177, which updates the invalid punycode tests. |
Renegade334
force-pushed
the
actions/truetools-update-ada
branch
from
July 28, 2026 15:01
7634ed8 to
cab619d
Compare
Member
|
Some of the tests in this repo needs to be removed as well. We shouldn't have unique tests related to URL when WPT is already covering it. It makes maintenance hell.. |
anonrig
reviewed
Jul 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64790 +/- ##
==========================================
- Coverage 90.16% 90.15% -0.01%
==========================================
Files 744 744
Lines 242518 242542 +24
Branches 45705 45695 -10
==========================================
+ Hits 218670 218673 +3
- Misses 15357 15364 +7
- Partials 8491 8505 +14 🚀 New features to boost your workflow:
|
anonrig
approved these changes
Jul 28, 2026
panva
approved these changes
Jul 28, 2026
panva
added
author ready
Renegade334
added
the
commit-queue-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ada to 4.0.0.